search

Sappharad / mp3gainOSX

MP3Gain Express for macOS
http://projects.sappharad.com/mp3gain/
96 stars 9 forks source link

List not updating after gain applied #4

Closed Sappharad closed 12 years ago

Sappharad commented 12 years ago

I received the following bug report via e-mail:

After applying gain (regardless of whether the analyze only operation was performed 
or the user pressed apply gain directly) the gain is applied but the list is not refreshed... 
it still shows the old volume and track gain, although the gain IS applied. I suspect this is 
because there is no call to refresh the list after the apply gain operation finishes.

I have not yet verified this to see if it occurs.

Sappharad commented 12 years ago

Unable to reproduce this problem. The list is refreshed for both analyze and apply, and when I tested applying gain to a file that had never been processed before everything appeared in the grid correctly after it was complete.

Closing this issue.

Sappharad commented 11 years ago

I got another e-mail reporting this problem, which made me realize what this report was about.

I worked through the process, and realized it was kind of confusing for users. If you Analyze files, then Apply gain, nothing in the list will change. This is normal, because you just applied the levels that you analyzed, and the grid is being updated with the exact same information that was there from analysis because that's what you applied. If someone were to analyze first, look at the numbers, decide what they want and change it up top, once they apply they'd see the grid change. (That's how I usually use the program)

I may consider some kind of additional feedback in the future so the user knows that the application did something. But this bug can remain closed because it's working as it was intended to.