Improve Exercise Form Field Titles

Sapphire-CM / Sapphire

MIT License

3 stars 0 forks source link

Improve Exercise Form Field Titles #586

Closed duaanakshbandi closed 2 years ago

duaanakshbandi commented 2 years ago

This PR fixes https://github.com/Sapphire-CM/Sapphire/pull/585

Q: Does a Rspec / test make sense here?

matthee commented 2 years ago

Regarding your question: No, I don't think we need tests for changing table headers.

IMHO tests should verify tasks critical tasks and data. If we were to break the table header in a future release, probably no-one would even notice for some time. Therefore, I think it is not worth to test those strings directly.

duaanakshbandi commented 2 years ago

Hello Matthias, thank you for your comments! ^^

I have updated the PR comment, hopefully this is what you mean, please let me know if I should change it elsewhere :)

matthee commented 2 years ago

Great! Thanks for your contribution!