SaptarshiSarkar12 / Drifty

Drifty is an Open-Source Interactive File Downloader System built with Java
https://saptarshisarkar12.github.io/Drifty/
Apache License 2.0
172 stars 120 forks source link

feat: Added Settings menu to Drifty GUI #544

Closed ziad-ashraf7 closed 2 months ago

ziad-ashraf7 commented 2 months ago

Fixes issue

Fixes #282

Changes proposed

Screenshots

image image

https://github.com/SaptarshiSarkar12/Drifty/assets/155207557/a09af69d-eee8-4814-903c-1b7a1aabb2fa

Note to reviewers

Summary by CodeRabbit

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
drifty āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Jun 26, 2024 10:30am
coderabbitai[bot] commented 2 months ago

Walkthrough

The changes integrate a new Settings menu into the Drifty GUI, enhancing user customization by allowing preferences such as the Last Download folder and Auto-Paste options. Major alterations span Java and resource files, fixing theme management and updating UI components, with a focus on improving usability and user settings.

Changes

Files/Directories Change Summary
.idea/inspectionProfiles/Project_Default.xml Added ESLint inspection tool to the project's default inspection profile.
Core/src/main/java/preferences/Get.java Converted preferences field and method lastDownloadFolder to static, added mainTheme method.
GUI/src/main/java/gui/preferences/{Clear,Labels,Set}.java Added and adjusted methods for main theme preferences handling and updates to Labels enum.
GUI/src/main/java/gui/support/Constants.java Incorporated conditional logic for different theme CSS files and image resources.
GUI/src/main/java/main/{Drifty_GUI,UIController}.java Refactored menu items, introduced Settings and About windows, updated theme-based CSS, unified duplicate logic, and added methods for new UI components.
GUI/src/main/java/ui/{ConfirmationDialog,About,Settings,UIComponentBuilder}.java Modified static members, added methods for displaying about information and settings, managing themes, UI component builders, and handling directory selections.
GUI/src/main/resources/CSS/Button.css Added bold font-weight styling to button states.
GUI/src/main/resources/META-INF/native-image/*.json Updated various method declarations and file paths for resources in configuration files.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Drifty_GUI
    participant Settings
    User->>+Drifty_GUI: Open Settings Menu
    Drifty_GUI->>+Settings: Show Settings Window
    Settings->>+User: Display Preferences
    User->>+Settings: Set Preferences (e.g., Theme, Auto-Paste)
    Settings->>+User: Save Preferences
    User->>+Drifty_GUI: See Updated Preferences

Assessment against linked issues

Objective (Issues) Addressed Explanation
Create a settings window in Drifty GUI for managing preferences (e.g., Last Download Folder, Auto-Paste) (#282) āœ…
Introduce a method to display the About window with application information (#282) āœ…
Update CSS and resources management based on main theme preferences (#282) āœ…

In Drifty's realm where settings hide, A rabbit hopped and beamed with pride. šŸ° For themes to switch and downloads placed, Auto-paste is now embraced. šŸŽ‰ Preferences set with much delight, Drifty's future is shining bright! šŸŒŸ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/preferences/Get.java:28:13: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/gui/preferences/Set.java:45:47: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/gui/preferences/Set.java:45:54: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:96:46: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/gui/support/Constants.java:99:90: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/gui/support/Constants.java:99:122: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/ui/UIController.java:93:9: Unused local variable 'disableStartButton'. [UnusedLocalVariable]
GUI/src/main/java/ui/UIController.java:100:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/UIController.java:124:9: 'method call' child has incorrect indentation level 8, expected level should be 12. [Indentation]
GUI/src/main/java/ui/UIController.java:125:37: '(' is followed by whitespace. [ParenPad]
GUI/src/main/java/main/Drifty_GUI.java:68:6: 'member def modifier' has incorrect indentation level 5, expected level should be 4. [Indentation]
GUI/src/main/java/main/Drifty_GUI.java:68:21: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/main/Drifty_GUI.java:78:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/main/Drifty_GUI.java:188:14: 'block' child has incorrect indentation level 13, expected level should be 12. [Indentation]
GUI/src/main/java/main/Drifty_GUI.java:188:56: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/main/Drifty_GUI.java:189:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/main/Drifty_GUI.java:197:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/main/Drifty_GUI.java:218:32: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/main/Drifty_GUI.java:219:13: Unused local variable 'settings1'. [UnusedLocalVariable]
GUI/src/main/java/ui/ConfirmationDialog.java:4:8: Unused import - gui.preferences.AppSettings. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:11:8: Unused import - javafx.scene.Node. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:18:8: Unused import - javafx.scene.paint.Color. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:22:8: Unused import - main.Drifty_GUI. [UnusedImports]
GUI/src/main/java/ui/Settings.java:3:8: Unused import - gui.init.Environment. [UnusedImports]
GUI/src/main/java/ui/Settings.java:6:8: Unused import - javafx.application.Platform. [UnusedImports]
GUI/src/main/java/ui/Settings.java:26:8: Unused import - java.util.prefs.Preferences. [UnusedImports]
GUI/src/main/java/ui/Settings.java:28:15: Unused import - preferences.Labels.LAST_FOLDER. [UnusedImports]
GUI/src/main/java/ui/Settings.java:35:62: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/Settings.java:37:14: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/ui/Settings.java:43:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:57:10: 'else' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:73:40: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/Settings.java:75:50: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/Settings.java:78:49: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/Settings.java:97:49: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:97:65: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:98:10: 'ctor def' child has incorrect indentation level 9, expected level should be 8. [Indentation]
GUI/src/main/java/ui/Settings.java:105:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:112:10: 'else' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:140:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:142:14: 'else' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:148:37: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:149:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:187:44: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:194:31: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/ui/Settings.java:195:45: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:202:13: '}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). [RightCurly]
GUI/src/main/java/ui/Settings.java:236:44: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:239:45: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:258:35: '(' is followed by whitespace. [ParenPad]
GUI/src/main/java/ui/Settings.java:307:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:313:39: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:320:27: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/ui/Settings.java:321:40: '->' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:328:10: 'else' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:338:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:343:14: 'else' is not followed by whitespace. [WhitespaceAfter]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/preferences/Set.java:45:47: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/gui/preferences/Set.java:45:54: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/UIController.java:94:9: Unused local variable 'disableStartButton'. [UnusedLocalVariable]
GUI/src/main/java/ui/UIController.java:125:9: 'method call' child has incorrect indentation level 8, expected level should be 12. [Indentation]
GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:96:46: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/gui/support/Constants.java:99:90: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/gui/support/Constants.java:99:122: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
GUI/src/main/java/main/Drifty_GUI.java:218:13: Unused local variable 'settings1'. [UnusedLocalVariable]
GUI/src/main/java/ui/ConfirmationDialog.java:4:8: Unused import - gui.preferences.AppSettings. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:11:8: Unused import - javafx.scene.Node. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:18:8: Unused import - javafx.scene.paint.Color. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:22:8: Unused import - main.Drifty_GUI. [UnusedImports]
GUI/src/main/java/ui/Settings.java:3:8: Unused import - gui.init.Environment. [UnusedImports]
GUI/src/main/java/ui/Settings.java:6:8: Unused import - javafx.application.Platform. [UnusedImports]
GUI/src/main/java/ui/Settings.java:26:8: Unused import - java.util.prefs.Preferences. [UnusedImports]
GUI/src/main/java/ui/Settings.java:28:15: Unused import - preferences.Labels.LAST_FOLDER. [UnusedImports]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/preferences/Set.java:45:47: ',' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/gui/preferences/Set.java:45:54: ')' is preceded with whitespace. [ParenPad]
GUI/src/main/java/ui/UIController.java:94:9: Unused local variable 'disableStartButton'. [UnusedLocalVariable]
GUI/src/main/java/ui/UIController.java:125:9: 'method call' child has incorrect indentation level 8, expected level should be 12. [Indentation]
GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:218:13: Unused local variable 'settings1'. [UnusedLocalVariable]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/UIController.java:94:9: Unused local variable 'disableStartButton'. [UnusedLocalVariable]
GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:97:5: '{' at column 5 should be on the previous line. [LeftCurly]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:97:5: '{' at column 5 should be on the previous line. [LeftCurly]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/main/Drifty_GUI.java:174:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:15:8: Unused import - javafx.scene.paint.Paint. [UnusedImports]
GUI/src/main/java/ui/Settings.java:224:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 227. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:97:5: '{' at column 5 should be on the previous line. [LeftCurly]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/main/Drifty_GUI.java:174:13: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:184:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 185. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:184:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 185. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:184:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 185. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:184:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 185. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:206:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 207. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:206:1: Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 207. [CommentsIndentation]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/gui/support/Constants.java:26:23: Name 'DRIFTY_MAIN_PNG' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:63:25: Name 'IMG_MAIN_GUI_BANNER' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/gui/support/Constants.java:64:25: Name 'IMG_SPLASH' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/main/Drifty_GUI.java:34:37: Name 'ap' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
Core/src/main/java/preferences/Get.java:27:38: Name 'preferences' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:


GUI/src/main/java/main/Drifty_GUI.java:36:31: Name 'aboutRoot' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:


GUI/src/main/java/main/Drifty_GUI.java:36:31: Name 'aboutRoot' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/Theme.java:12:8: Unused import - javafx.scene.layout.VBox. [UnusedImports]
GUI/src/main/java/ui/Theme.java:19:8: Unused import - java.util.ArrayList. [UnusedImports]
GUI/src/main/java/main/Drifty_GUI.java:36:25: Name 'ABOUT_ROOT' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/ui/ConfirmationDialog.java:12:8: Unused import - javafx.scene.Node. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:19:8: Unused import - javafx.scene.paint.Color. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:23:8: Unused import - main.Drifty_GUI. [UnusedImports]
GUI/src/main/java/ui/ConfirmationDialog.java:170:9: 'if' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:8:8: Unused import - javafx.scene.Node. [UnusedImports]
GUI/src/main/java/ui/Settings.java:16:8: Unused import - javafx.scene.paint.Paint. [UnusedImports]
GUI/src/main/java/ui/Settings.java:30:35: Name 'tfCurrDir' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Theme.java:4:8: Unused import - gui.preferences.Set. [UnusedImports]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/Settings.java:26:35: Name 'tfCurrDir' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/main/Drifty_GUI.java:36:25: Name 'ABOUT_ROOT' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:


GUI/src/main/java/ui/Settings.java:27:25: Name 'button' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/Settings.java:23:21: Name 'AUTO_PASTE_CHECKBOX' must match pattern '^[a-z][a-zA-Z0-*$'. [MemberName]
GUI/src/main/java/ui/Settings.java:23:40: ';' is not followed by whitespace. [WhitespaceAfter]
GUI/src/main/java/ui/Settings.java:24:30: Name 'TF_CURRENT_DIRECTORY' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/ui/Settings.java:25:19: Abbreviation in name 'LBL_DEFAULT_DOWNLOAD_DIR' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:26:19: Abbreviation in name 'LBL_THEME' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:27:19: Abbreviation in name 'SETTINGS_HEADING' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:28:19: Abbreviation in name 'LBL_AUTO_PASTE' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:29:27: Name 'SELECT_DIRECTORY_BUTTON' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/ui/Settings.java:39:29: Abbreviation in name 'getTF_CURRENT_DIRECTORY' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/gui/utils/UIComponentBuilder.java:67:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '50'. [OverloadMethodsDeclarationOrder]
GUI/src/main/java/ui/Theme.java:4:8: Unused import - gui.preferences.Set. [UnusedImports]
GUI/src/main/java/ui/Theme.java:83:9: 'if' construct must use '{}'s. [NeedBraces]
GUI/src/main/java/main/Drifty_GUI.java:5:8: Unused import - gui.preferences.Set. [UnusedImports]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/Settings.java:23:21: Name 'AUTO_PASTE_CHECKBOX' must match pattern '^[a-z][a-zA-Z0-*$'. [MemberName]
GUI/src/main/java/ui/Settings.java:24:30: Name 'TF_CURRENT_DIRECTORY' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/ui/Settings.java:25:19: Abbreviation in name 'LBL_DEFAULT_DOWNLOAD_DIR' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:26:19: Abbreviation in name 'LBL_THEME' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:27:19: Abbreviation in name 'SETTINGS_HEADING' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:28:19: Abbreviation in name 'LBL_AUTO_PASTE' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/ui/Settings.java:29:27: Name 'SELECT_DIRECTORY_BUTTON' must match pattern '^[a-z][a-zA-Z0-*$'. [StaticVariableName]
GUI/src/main/java/ui/Settings.java:39:29: Abbreviation in name 'getTF_CURRENT_DIRECTORY' must contain no more than '4' consecutive capital letters. [AbbreviationAsWordInName]
GUI/src/main/java/gui/utils/UIComponentBuilder.java:67:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '50'. [OverloadMethodsDeclarationOrder]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:

GUI/src/main/java/ui/About.java:24:36: Name 'ivSplash' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
GUI/src/main/java/ui/Settings.java:106:147: ',' is not followed by whitespace. [WhitespaceAfter]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:


GUI/src/main/java/ui/UIController.java:60:34: Name 'infoTf' must match pattern '^[A-Z][A-Z0-*(_[A-Z0-9]+)*$'. [ConstantName]
github-actions[bot] commented 2 months ago

:x: Linting errors found!

@ziad-ashraf7 Please fix the following errors:


GUI/src/main/java/ui/UIController.java:72:28: Name 'getINFO_TF' must match pattern '^[a-z][a-zA-Z0-*$'. [MethodName]