search

SapuSeven / BetterUntis

An alternative mobile client for the Untis timetable system.
GNU General Public License v3.0
240 stars 34 forks source link

Updated Translations and Widget Preview #400

Closed user0-07161 closed 1 year ago

user0-07161 commented 1 year ago

Updated some german translations and updated widget preview to show that there is a dark mode for the widget.

Widget Preview:

WidgetPreview

SapuSeven commented 1 year ago

Hi, Thanks for your interest in improving BetterUntis.

Please take a look at the Contributing-Section of the Readme file. It explains how to edit translations and where to open a pull request. I cannot merge your changes into master.

Regarding the updated preview Image: You seem to have mistakenly removed the alpha channel. If you look at the original image, you can see a transparent border around the image - your edit missed that. Also I feel that the dark background is too dark - take a look at the actual app with the original red color theme in dark mode and pick the dark color from there. Lastly, I see some artifacts around parts of the grey line on top of the dark background.

Ultimately, I'm not too sure about this idea. I looked at other apps and for example the Google Calendar app manages to have different colored previews for light and dark mode: Maybe we could have a look at how they did it. Screenshot_20230723-125735 Screenshot_20230723-125721

user0-07161 commented 1 year ago

Hello SapuSeven,

in https://developer.android.com/develop/ui/views/appwidgets/enhance#dynamic-colors it says that as of android 12 it is possible to create different previews for dark/light mode. Therefore, many people are still using an older android version, I think it will not be possible to add this in BetterUntis.

lm41 commented 1 year ago

https://developer.android.com/develop/ui/views/appwidgets/enhance#backward-compatibility

There is backwards compability.

lm41 commented 1 year ago

See https://github.com/SapuSeven/BetterUntis#translating-into-another-language

SapuSeven commented 1 year ago

Given the feedback I will close this PR. Translations can be done on weblate (see @lm41 's comment), and I agree that the app should take advantage of the modern dynamic widget preview approach. If you want to work on it, feel free to open another PR, and keep the README instructions in mind ;)