search

SapuSeven / BetterUntis

An alternative mobile client for the Untis timetable system.
GNU General Public License v3.0
234 stars 33 forks source link

[Bug Report] #370 doesn't work in the latest beta version (4.0.2) #407

Closed Lauritz-Tieste closed 5 months ago

Lauritz-Tieste commented 1 year ago

Unfortunately the error still occurs even though it was fixed by the PR.

Android Version

Android 13

BetterUntis Version

4.0.2 (28227720)

Installation Source

GitHub Release

SapuSeven commented 1 year ago

Did you test the changes when you made the PR? I myself haven't been able to replicate the issue at all, so I can't really help...

Lauritz-Tieste commented 1 year ago

Yes, I tested it and it worked perfectly

SapuSeven commented 1 year ago

That's weird. Maybe we need an entirely different approach to control when the drawer can be opened.

Lauritz-Tieste commented 1 year ago

I'll take a look at it

Lauritz-Tieste commented 1 year ago

The changes are not included in the source code on the dev branch!

SapuSeven commented 1 year ago

Can't confirm. I looked at the source code attached to the 4.0.2 release, as well as the current dev branch. They both include the PR changes.

Lauritz-Tieste commented 1 year ago

The changes of 28968905a0922921316149c42be4c3ede2428cdb caused the error again

Lauritz-Tieste commented 1 year ago

I myself haven't been able to replicate the issue at all, so I can't really help...

To reproduce it: You have to quickly swipe in one direction on the timetable several times. Then the drawer should open

SapuSeven commented 1 year ago

Given my comment in #408 - is it possible that this error happens when you (accidentally) start the swipe too far to the left edge?

Lauritz-Tieste commented 10 months ago

Detailed description for #370, #407 and #408

Steps to reproduce the error:

  1. Open BetterUntis
  2. QUICKLY swipe through the timetable (right/left), as if you wanted to quickly go 8 weeks into the future.

After a while, the NavigationDrawer accidentally opens on all of my devices.

For reproducing the error, it might be useful to test this on a real phone, rather than an emulator.

Given my comment in #408 - is it possible that this error happens when you (accidentally) start the swipe too far to the left edge?

@SapuSeven No, this error also occurs if you only swipe in the middle of the screen and leave 2cm between swiping and the edge of the screen

Lauritz-Tieste commented 5 months ago

I was no longer able to cause the error in the latest version (4.1.0-beta-01 28334728).