Some improvements

[igarrido-adalab]

Really cool job @Sara-Gavi !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• [x] Execute getRandomNumber function when the page loads.
• [x] Extract the feedback painter to a function.
• [ ] Watch out for constant names used to save DOM references... Do we want to use the DOM reference or that DOM element content (innerHTML/value)? (i.e. userNumber or attempsCounter)

JavaScript: advanced

• [x] Move your counter of tries logic into a function and execute it on each click (this lines https://github.com/Adalab/modulo-2-evaluacion-intermedia-Sara-Gavi/blob/6fa71a71b03ee2ec4b326629c7d0f63b52849b3f/Js/main.js#L36-L37).
• [ ] You are writing many times "clueEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'clueEl'?

JavaScript: good practices

• [x] Move variables and constants declarations to the top of the file.
• [x] Declare your global variables at the beginning of the JavaScript file (after querySelector section).
• [ ] Use === instead of == for comparisons.
• [x] Use addEventListener instead of onClick to register event listeners.

Good practices

• [x] Make multiple commits as you work.
• [x] Try to improve your commits messages. "Add JS" is a bit poor. "Add random number logic" is more explanatory.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Add a reset button that cleans the tries counter, generates a new random number and writes the initial feedback.
• Show the restart game button when the game is over and hide the test button.
• Complete the code needed for the restart game button.
• Add a limit for the numbre of tries. If the user reaches that limit, the page announces that "The game is over".
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

From now on you can commit your changes to the main branch of your project. Do not close this issue until your teacher asks you to

[Sara-Gavi]

Thanks @igarrido-adalab Ivan ! for the recommendations and improvements. I have created more functions to make the code easier to read and understand. Also, I have made some changes and I have also created an event and function for a new reset button.