search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

Ask for video link instead of video ID in "Add a Talk" #111

Closed scriptnull closed 6 years ago

scriptnull commented 6 years ago

I would like to start by saying that awesometalks.party is totally awesome ✨ and I have been using it for a while to watch videos. Recently I wanted to add a talk to the curation and saw this

screen shot 2018-08-18 at 12 03 40 pm

I feel that it would be more intuitive for people to paste a link to video instead of video ID.

Because, I wandered for sometime to find out the video ID, which I think is supposed to be derived from the link https://www.youtube.com/watch?v=VIDEO_ID (still doubtful) 🤔

SaraVieira commented 6 years ago

Hey!!

Awesome that you love the website 😍

You may have an old version of the page because of the service worker we had in the beginning :(

Can you try hard refreshing? If it doesn't work let me know and I will upload an unregister service worker

This has already been addressed as some people had the same doubt so now you paste the YouTube link and the code cleans that out and gets the video ID :)

scriptnull commented 6 years ago

Thanks, 👍 I hard refreshed and I am able to see the new version (lol, I had missed out a lot of cool stuff like dark mode all these days 😆 )

But, I think there might be something weird going on. Because, when I visit the site next time in a new tab, it is still loading the old version. Hence I need to hard refresh every time after visiting the site.

SaraVieira commented 6 years ago

Oh! That is not good :(

Can you please tell me the path of the service worker? So I can push a change to unregister it?

On Sat, 18 Aug 2018, 09:44 Vishnu Bharathi, notifications@github.com wrote:

Thanks, 👍 I hard refreshed and I am able to see the new version (lol, I had missed out a lot of cool stuff like dark mode all these days 😆 )

But, I think there might be something weird going on. Because, when I visit the site next time in a new tab, it is still loading the old version. Hence I need to hard refresh every time after visiting the site.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/SaraVieira/awesome-talks/issues/111#issuecomment-414039354, or mute the thread https://github.com/notifications/unsubscribe-auth/ABALdb4FaW5YxnG1zM0kz1B4uePaMNYkks5uR8XSgaJpZM4WCdlZ .

--

Thank you Sara Vieira

SaraVieira commented 6 years ago

Also, can you please it in another issue :)

Thank you for letting me know :)