SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

why use injectGlobal and remcalc? #26

Closed tsiq-swyx closed 6 years ago

tsiq-swyx commented 6 years ago

Hi Sara! just trying to learn from your code!

I notice in https://github.com/SaraVieira/awesome-talks/blob/master/src/Utils/global-styles.js you use injectGlobal from styled-components, together with remcalc.

I do use css-in-js but normally here i'd just have a global.css and import it, and just use rem's everywhere.

I'm not disagreeing with you here, just thought it was an interesting technical choice, and maybe something I can learn from. Wonder if you could talk a little about why you use injectGlobal + remcalc instead of other maybe more common approaches? thanks very much!

SaraVieira commented 6 years ago

Hey !

Hi Sara! just trying to learn from your code!

That's your mistake right there 😂

Wonder if you could talk a little about why you use injectGlobal + remcalc instead of other maybe more common approaches?

I don't have a specific reason but some reasons why I started coding this way with styled components.

It may look a little weird and overly complicated at first glance I'll give you that ahah

All of that said this my way of coding and like anything it's subjective but I hope that makes sense to you 😄

tsiq-swyx commented 6 years ago

interesting. thank you very much! yea i know css in js is a very very unsolved problem so i'm always on the look out for how other people do it. i'm sure what i do (pure css + style tag 90% of the time, then styled-components) can't really be the "best" way.