SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
810 stars 61 forks source link

Feature request: Save for later/bookmark #72

Closed siddharthkp closed 2 years ago

siddharthkp commented 6 years ago

Sometimes you see a talk you want to watch, but can't do it right now

Save it for later?

sudovijay commented 6 years ago

Yes kinda add to watch list, sounds a good idea to me and easy to implement too

pksjce commented 6 years ago

Isnt this the same as "Favorite"-ing feature we have right now?

siddharthkp commented 6 years ago

Favorite = This was such a good talk that I just watched, let me ❤️ it so that I can save it to my list and comes in recommendations for other people (popular talks)

Bookmark = I don't know If I'd like this talk but I'm a sucker for clickbaits, let me save it for later. After I watch it, I'll remove it from my bookmarks

There is an overlap, you can favorites for bookmarks, but shouldn't?

sudovijay commented 6 years ago

Bookmark doesn't sound good, it's a video. Something like Watch Later sounds good to me, Favorite is more or less similar to Liked Videos. if we really wanna do this all we gotta do is add a icon below Watched talks, everything else will be like fav.

pksjce commented 6 years ago

But we currently don't have the concept of a "User" in the app right? How will you store this info beyond the current session?

sudovijay commented 6 years ago

We don't need "User" concept for that, its all localStorage / Cookies (which of course has less limit), just like we doing for fav. NO, wait. we're not doin' anything lol it even doesn't seem to store favs longer than session. is it due to SSR ?

sudovijay commented 6 years ago

localStorage seems to work fine, it just we need to re render few stuff when the app did actually get mounted on client side. otherwise there's no point of having fav or watched talks.

siddharthkp commented 6 years ago

But we currently don't have the concept of a "User" in the app right? How will you store this info beyond the current session?

🤔 I'm not sure, how do we store favorites/already seen right now?

SaraVieira commented 6 years ago

🤔 I'm not sure, how do we store favorites/already seen right now?

Local storage