search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

small a11y improvements #74

Closed scottaohara closed 6 years ago

scottaohara commented 6 years ago

this PR adds the following a11y updates:

  1. wrap the navigation and search components into a global banner landmark
  2. change the logo alt text from “logo” to “home” as that’s a more meaningful announcement to its purpose.
  3. the “add a talk” button was keyboard inaccessible, adding a role=“button” and tabIndex=“0” allows screen reader users to hear its intended role and access it with the tab key (another issue will be made about this element)
  4. wrap the search component in a role=“search” to add it to the listing of landmarks in the application. Add an aria-label to the input.
sudovijay commented 6 years ago

@scottaohara seems good bud, i quess i'm gonna take web accessibility course now , probably others can review this better. onto ya @SaraVieira now

SaraVieira commented 6 years ago

Thank you so much @scottaohara ! All looks great ! I will merge and deploy these fixes now and also run axe on the website to try and find more issues !

Thank you ❤️

scottaohara commented 6 years ago

Thank you both.

There are some other updates I'd like to make, so I'll open some other PRs/Issues in the not too distant future.

@SaraVieira lemme know if you have any questions on any issues you find/want to fix yourself :)

SaraVieira commented 6 years ago

@scottaohara I found some more stuff to fix and tagged you here https://github.com/SaraVieira/awesome-talks/pull/76

Thank you