search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
810 stars 61 forks source link

Handling events #80

Closed sudovijay closed 6 years ago

sudovijay commented 6 years ago

Notice this weird issue while escaping search and cinema at the same time, same with modal So fixed it

sudovijay commented 6 years ago

While clicking on turn on cinema mode escape event works fine but going through click on thumbnail it just doesn't emit. idk y. so added a global event which works fine but doesn't look good to me. can't add this on componentDidMount either as multiple event listener get attached. so it'll be great if anyone can take a look on this.

SaraVieira commented 6 years ago

@sudovijay So the deployment is failing because the secrets are not shared between forks so you can either work on this repo or please can you follow this guide for your fork: https://github.com/siddharthkp/now-cd

sudovijay commented 6 years ago

Secrets should never be shared , JK🙂