search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

Video thumbnail image size #86

Closed cain closed 6 years ago

cain commented 6 years ago
screen shot 2018-06-06 at 10 56 36 am

Image thumbnails look pretty bad on retina screens due to the size. And it looks like all the other resolutions youtube provide dont really work with our 3 column layout.

Thoughts on a 4 column layout instead?

screen shot 2018-06-06 at 11 08 34 am
sudovijay commented 6 years ago

we could implement something like srcset here, anyway @cain did you tried other reso. that youtube provide

https://img.youtube.com/vi/NAimzL6XXAY/mqdefault.jpg https://img.youtube.com/vi/NAimzL6XXAY/hqdefault.jpg https://img.youtube.com/vi/NAimzL6XXAY/maxresdefault.jpg

the one with maxres should look fine i quess.

SaraVieira commented 6 years ago

You are right ! This was something I did in the beggining to avoid a lot of images loaded but now we are only loading 10 so we can get better images :D

I will try other resolutions today and see how high we can get without having some videos without images :)

SaraVieira commented 6 years ago

Fixed by https://github.com/SaraVieira/awesome-talks/commit/31273f98a8fc6631caf210a37d82d25e65d97afb

Four column layout would make it to squished , I would rather go for a two column layout

sudovijay commented 6 years ago

lets close this for now, three column layout seems perfect too me 🙂