search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

Adding Some cookies 🍪 #89

Closed sudovijay closed 6 years ago

sudovijay commented 6 years ago

Did set cookie expiry to 365 Days, I quess that'll be more than enough.

SaraVieira commented 6 years ago

Duuude this is awesome !

SaraVieira commented 6 years ago

We need the banner tho :(

sudovijay commented 6 years ago

Work in progress, making one. trying to avoid any more lib, lets see otherwise gonna use React Cookie Banner lol

SaraVieira commented 6 years ago

Let me know when you add it so I can make a new release :D

sudovijay commented 6 years ago

@SaraVieira its all yours now 🙂

SaraVieira commented 6 years ago

@sudovijay I think the banner should only appear on the client otherwise we get the flash even if we already saw it :(

SaraVieira commented 6 years ago

Fixed the flash and I am just going to wait for the ckecks to merge and deploy :D

sudovijay commented 6 years ago

opps, forget about it, we dealing with some SSR here lol

sudovijay commented 6 years ago

thats a clever fix 👏

SaraVieira commented 6 years ago

clever means hacky and I like it ahah

sudovijay commented 6 years ago

not exactly hacky, if it works its all valid / clever :)

SaraVieira commented 6 years ago

Merged and deployed ! https://awesometalks.party/

Pretend I said thanks and you got mad ahah

I shall tweet about this after dinner :D