search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

Turn Cinema Mode into Toggle Button #98

Closed Fausto95 closed 5 years ago

Fausto95 commented 6 years ago

Hey Sara, The actual Turn Cinema Mode is less interactive. So this PR comes to turn it into a toggle button the same as the Hide Watched Talks!

capture d ecran 2018-06-10 a 13 49 33
cain commented 6 years ago

Sorry looking at the screenshot, this doesnt make sense to me. How does this work with multiple videos, can you turn on multiple cinema modes? Can you show me a gif of how this works, thanks! 😄

Fausto95 commented 6 years ago

awesome talks This is how it works!

But wait... cinema mode for multiple videos ?

cbh6 commented 6 years ago

I think what @cain means is that these toggle buttons feel like you could turn multiple videos into cinema mode at the same time.

Fausto95 commented 6 years ago

But you can't. I think it's better than having just de red text, is kinda difficult to figure out that they're clickable!