search

SaraVieira / awesome-talks

Awesome Talks Curated By the Community
MIT License
809 stars 62 forks source link

Improve Cinema Modal Border an alignment #99

Closed Fausto95 closed 5 years ago

Fausto95 commented 6 years ago

The alignment in the actual Cinema Mode is kinda messed up on the bottom. I think it'd cool to have it right in the middle!

Before:

capture d ecran 2018-06-10 a 17 42 22

After:

capture d ecran 2018-06-10 a 17 18 39

Dark Mode Improvements

When we're with the Dark Mode activated, it's a little bit difficult to figure out where to click to quit or event just to see the size of it!

So I put a border so that way people can actually see it!

Before:

capture d ecran 2018-06-10 a 17 33 30

After:

capture d ecran 2018-06-10 a 17 32 46
Fausto95 commented 6 years ago

Oh this has also the changes of the #98! I was working on master directly 😂 .. my bad

cain commented 6 years ago

Looks like you have combined both of your PR's. Can you please fix this up. 😄