SaraVieira / fiddly

Create beautiful and simple HTML pages from your Readme.md files
https://fiddly.netlify.com
MIT License
1.01k stars 39 forks source link

Image not found #16

Closed hawkins closed 5 years ago

hawkins commented 5 years ago

Not sure what I'm doing wrong, but the following image that shows up on GitHub does not get copied into the public folder and is thus not found when deployed:

 ![Screenshot of Lard 0.0.0 folder view for 'Coding'](screenshots/folder.png)

For reference, I'm testing using https://github.com/hawkins/lard 's master repo as a "no-config" test since it has no .fiddly.config or package.json

hawkins commented 5 years ago

The <img> tag is included, however, so I'm fairly positive this is user error 😅 https://public-vmbngwkvmw.now.sh

SaraVieira commented 5 years ago

Soooo I figured out the issue:

The filsystem doesn't recognize this as path:

screenshots/folder.png

so you need to make it like so and it works well

![Screenshot of Lard 0.0.0 folder view for 'Coding'](./screenshots/folder.png)

I am actually kind of amazed that worked on Github 🤔

SaraVieira commented 5 years ago
screenshot 2018-12-28 at 20 10 12
hawkins commented 5 years ago

I just caught that myself as well, had literally typed a message to close this and everything. You're a ninja! Thanks so much.

SaraVieira commented 5 years ago

https://media1.giphy.com/media/EPaebv5YaeqWs/giphy.gif?cid=3640f6095c2683ad6c484b642ee85df1

NINIJA CAT