SaraVieira / opnionated-guide-to-react

0 stars 0 forks source link

Repo Gone :( #1

Open itzjonas opened 4 years ago

SaraVieira commented 4 years ago

Hey 👋

I'm sorry I made it private once I started selling the book

Still thinking about the best way of doing this

mjsarfatti commented 4 years ago

You can buy it here for an extremely reasonable price ;) https://leanpub.com/opinionated-guide-to-react

Ps @SaraVieira might want to add the link as a README here? Took me some work to find it on LeanPub 😅

SaraVieira commented 4 years ago

Hey!

I will, it's still weird to me that when you make a repo private the remains of the public stay online 😂

Thank you for letting me know

mjsarfatti commented 4 years ago

Oh you made it private. I thought you had emptied it (somehow)... Very weird!

On Mon, 4 May 2020, 12:31 Sara Vieira, notifications@github.com wrote:

Hey!

I will, it's still weird to me that when you make a repo private the remains of the public stay online 😂

Thank you for letting me know

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SaraVieira/opnionated-guide-to-react/issues/1#issuecomment-623385891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFTYPHRMSSUZYRY2PHH2DTRP2KQNANCNFSM4KJVZRWA .

luc4leone commented 3 years ago

Hi Sara, is this the right place for questions about the book content?

First of all: great book!

Question example

Context:

It didn't work for me when I wrote, as written in the book, import Alert from "./components/Alert";. But it did work when I added / at the end of the statement, like so: import Alert from "./components/Alert/";

Did you forget the / or am I missing something? Thanks!

SaraVieira commented 3 years ago

Hey!

Can you tell me what is your set up?

It seems to work in this example: https://codesandbox.io/s/nervous-architecture-nj77s?file=/src/App.js

luc4leone commented 3 years ago

I used Create React App and then I installed CRACO (https://tailwindcss.com/docs/guides/create-react-app#install-and-configure-craco), to use tailwind.

I reproduced your example locally, added CRACO and had no problems (which surprised me). But when instead of exporting a function - your Alert - I exported a React subclass then I get the error.

SaraVieira commented 3 years ago

Can you please share the code?

luc4leone commented 3 years ago

hey @SaraVieira it looks like I've been wasting your time, sorry. I was ready to share the code, but when I made a final check before pushing it to github... it was working! "How come?!" I asked myself. Couldn't have been some sloppy typo, I triple checked it. After lots of experiments, it seems that I have to restart the server. Some times I don't have to. I am still figuring out when that's necessary. But when I restart it, skipping /index.js always works. Thanks :)

luc4leone commented 3 years ago

In the book you didn't mention testing the app. Is there a reason? I'd very much like to know your opinion on it.

SaraVieira commented 3 years ago

Hey!

So sorry for the delay here :/

Really happy it worked! It is weird you need to restart it :/

About the testing, I am now working on that chapter and will release it soon 🙂

Honestly I didn't add it because I didn't see it that much connected to react, most of the tests I do are cypress tests and unit tests but to pure javascript functions or api calls

luc4leone commented 3 years ago

looking forward to reading the new chapter!

asdiasx commented 3 years ago

Hi! This book is on my favorites list at leanpub but not available to buy... :( Where can I find it? Regards

SaraVieira commented 3 years ago

Hey!

I decided to sell it on my own, you can get it on the website here: https://opinionatedreact.com/

Thank you!