SarahWeiii / CoACD

[SIGGRAPH2022] Approximate Convex Decomposition for 3D Meshes with Collision-Aware Concavity and Tree Search
https://colin97.github.io/CoACD/
MIT License
482 stars 64 forks source link

add persistence #46

Closed laurentopia closed 4 months ago

laurentopia commented 5 months ago
eliphatfs commented 5 months ago

Hi laurentopia, thank you for contributing to CoACD! I looked into the code and I like the idea of storing meshes on the same GameObject and persistence of mesh data automatically. However, the current dependency on SaintsField.Playa may cause confusion on the usage without reading the code or instructions on the editor extensions, and the EditorUtility call would make the code fail to compile on build. I would like to accept the PR but also make some changes after.

laurentopia commented 4 months ago

I put conditionals around the saintsfield so it shouldn't affect ppl not using it. But I see that I also removed the context menu, let me add it back. Would that work?