search

SarahWeiii / CoACD

[SIGGRAPH2022] Approximate Convex Decomposition for 3D Meshes with Collision-Aware Concavity and Tree Search
https://colin97.github.io/CoACD/
MIT License
457 stars 59 forks source link

triangle.h replaced by CDT #5

Closed Abde5 closed 1 year ago

Abde5 commented 1 year ago

Dear Wei, Liu, Ling and Su,

As you have noted in the README.md and as discussed in #4, triangle.h is not MIT compatible. I have replaced this library by CDT which gives similar results in terms of quality and does not deteriorate the convergence of CoACD. CDT is MPL2, which is a lot more permissive than the license of triangle.h.

This pull request has been tested on a Windows 11 machine, compiled with Visual Studio 2022 17.3.6.

I did not delete the triangle.h library and you still can use it. You must add the preprocessor macro #define TRIANGLE in order to use it. By default, it will use CDT.

This work is being contributed by Altheria Solutions.

SarahWeiii commented 1 year ago

Hi, thank you so much for the contribution! I have tested the CDT code on VHACD dataset (including 61 objects) using the default settings on Ubuntu 20.04 and it works well. Though the speed of CDT is slower than triangle.h, the gap is not large. The average processing time (/s) is shown below:

CDT | triangle.h 43.72 | 39.05

I will merge the code into the main branch.