Saransh-cpp / BookRentApp-Chapter3

An app where you can rent some books!
12 stars 27 forks source link

Add Google Sign In #10

Closed Saransh-cpp closed 2 years ago

Saransh-cpp commented 2 years ago

Description

I think the Google Sign In has been implemented but has not been added to the frontend. Add it to the Register and Log In screen with all the necessary data. Adding this as hard as this will require passing the data in between files or initializing dummy data.

Relevant files

mortal-ghost commented 2 years ago

Can I work on this?

Saransh-cpp commented 2 years ago

Yes, go ahead!

mortal-ghost commented 2 years ago

Can you please confirm if google sign in is enabled in firebase?

Saransh-cpp commented 2 years ago

image

Yes, do you want me to add you as a viewer in Firebase? If so, please drop your mail below.

mortal-ghost commented 2 years ago

anmoldeepsingh148@gmail.com

Saransh-cpp commented 2 years ago

image

Done!

mortal-ghost commented 2 years ago

I have written the code but the googleSignIn() function in auth.dart keeps giving me the same error. Error => PlatformException(sign_in_failed, com.google.android.gms.common.api.ApiException: 10: , null, null) The error occurs on the second line of this function. I have searched about the error and keeps getting the same answer that there is some problem with firebase authentication. Here is a link to a stackoverflow answer I referred to -> https://stackoverflow.com/questions/54557479/flutter-and-google-sign-in-plugin-platformexceptionsign-in-failed-com-google I have checked the firebase. The chapter-3 app does have a sha1 key but the chapter3-admin does not. Is it possible that might be causing the error?

mortal-ghost commented 2 years ago

While working on the issue, I found another issue. On the home screen, the SingleChildScrollView widget is giving out an error. Can I raise this issue?

Saransh-cpp commented 2 years ago

Pointed out in #39

Saransh-cpp commented 2 years ago

I'll have a look at the error today

mortal-ghost commented 2 years ago

Thank you. I found another issue in the app. When you login with invalid credentials, the app logs in anyway with errors. Please take a look at this one too.

Saransh-cpp commented 2 years ago

Can you create a new issue with some screenshots or more details?

mortal-ghost commented 2 years ago

Yes I will

Saransh-cpp commented 2 years ago

I have written the code but the googleSignIn() function in auth.dart keeps giving me the same error. Error => PlatformException(sign_in_failed, com.google.android.gms.common.api.ApiException: 10: , null, null)

@mortal-ghost, can you create a PR so I can have a look?

mortal-ghost commented 2 years ago

I have created a PR. Can I start working on other issues ?