search

Saransh-cpp / BookRentApp-Chapter3

An app where you can rent some books!
12 stars 27 forks source link

created a AboutUs screen-fixed issue#27 #49

Closed Pranav108 closed 2 years ago

Pranav108 commented 2 years ago

This Pull Request is about issue #27 ,here I created a AboutUs screen which shows us a brief info about this app and it's contributors along with the working link to their respective profile. I have to use http package in this issue which caused a lot version confliction with firebase packages. So finally I also updated each dependency to their latest version keeping version confliction, null safety and other upcoming problems in mind. And during solving relative errors I also updated minSdkVersion and targetSdkVersion. And I haven't attached this screens to any option yet because even after several attempt I didn't find anything on home screen to attach with.

Saransh-cpp commented 2 years ago

@Pranav108, was there a template provided when you opened the PR, or was there none? (#44 should have had added a template but I'm not sure if it is working)

Pranav108 commented 2 years ago

@Pranav108, was there a template provided when you opened the PR, or was there none? (#44 should have had added a template but I'm not sure if it is working)

I don't think so(or maybe few minutes before) because I was going through this repo whole day and must had noticed this kind of change. And in hurry I forgot to give a last touch to the code. I should have removed those extra comments, I will take care of this things from next time.

Pranav108 commented 2 years ago

I'm getting an option of 'resolve conversion' here, so I have to change it or you are improving it? This is first time I'm going though this things, so don't know how to proceed.

Saransh-cpp commented 2 years ago

I'm getting an option of 'resolve conversion' here, so I have to change it or you are improving it? This is first time I'm going though this things, so don't know how to proceed.

These are some suggestions that should be implemented in this PR. You can do so directly from GitHub using the Commit suggestion button. I'll resolve the conversation once the suggestions are implemented, no worries!

Saransh-cpp commented 2 years ago

@Pranav108, can you merge the master branch of the main repository in this branch? Your branch is 20 commits behind, hence the home screen error (which has been fixed in the master branch). image

Let me know if you need any help:) !

Pranav108 commented 2 years ago

@Pranav108, can you merge the master branch of the main repository in this branch? Your branch is 20 commits behind, hence the home screen error (which has been fixed in the master branch). image

Let me know if you need any help:) !

I just did it, was that correct? I may have fetched only to my main branch and I was working on another branch that's may be the reason for home screen error to still be on my code.

Pranav108 commented 2 years ago

Thanks for your suggestion, they really improved the view and code for screen a lot. I also removed some redundant code as far I found them. Let me know about further improvement that need to be added. This is the layout till now. AboutUsImprovementSection

Saransh-cpp commented 2 years ago

@all-contributors please add @Pranav108 for code, design

allcontributors[bot] commented 2 years ago

@Saransh-cpp

I've put up a pull request to add @Pranav108! :tada: