Saransh-cpp / BookRentApp-Chapter3

An app where you can rent some books!
12 stars 27 forks source link

Implement "All contributors" section #7

Closed Saransh-cpp closed 2 years ago

Saransh-cpp commented 2 years ago

Description

It would be nice to have an all contributors section in the README file.

References

Preference 1 - https://github.com/pybamm-team/PyBaMM#-contributors Preference 2 - https://github.com/smaranjitghose/DocLense#our-valuable-contributors-

Let me know if I have to enable something in order to implement this!

Pranav108 commented 2 years ago

Can I work on it?

Saransh-cpp commented 2 years ago

Sure, go ahead! Try to implement the Preference 1 section.

Pranav108 commented 2 years ago

I have created a readme.md consist of 5 contributors. Here I can see 5 account who have contributed to master, excluding merge commits and bot accounts. So I have to add these 5 users only, right? And if we want to aadd all contributors, then adding all_contributors_bot🤖 would be the best option.

Saransh-cpp commented 2 years ago

Let me try this

Saransh-cpp commented 2 years ago

@all-contributors please add @Saransh-cpp for code

allcontributors[bot] commented 2 years ago

@Saransh-cpp

I've put up a pull request to add @Saransh-cpp! :tada:

Saransh-cpp commented 2 years ago

Oh this was easy XD I'll ask the CodePeak admins about how to mark you on this

Saransh-cpp commented 2 years ago

I've marked you accordingly! Thanks for the quick fix!

Saransh-cpp commented 2 years ago

@all-contributors please add @Pranav108 for ideas

allcontributors[bot] commented 2 years ago

@Saransh-cpp

I've put up a pull request to add @Pranav108! :tada: