Saransh-cpp / BookRentApp-Chapter3

An app where you can rent some books!
12 stars 27 forks source link

Issue 45 login without credentials #72

Closed mortal-ghost closed 2 years ago

mortal-ghost commented 2 years ago

Issue

Fixes #45

Description

Only one change in the lib/Screens/LoginPage.dart Home screen was pushed on validating form conditions without validating the credentials. Minor change to lib/Provider/user.dart regarding the google sign in issue. Calling the createUser function on signing in.

Type of change

You can write manually also

Checklist:

Saransh-cpp commented 2 years ago

@mortal-ghost, please merge in master of my repository.

mortal-ghost commented 2 years ago

@mortal-ghost, please merge in master of my repository.

Can you please help me regarding this?

Saransh-cpp commented 2 years ago

Can you please help me regarding this?

Can you tell me what git remote -v shows you?

Saransh-cpp commented 2 years ago

And no need to close this PR, you can keep pushing commits in your branch and they will automatically appear in this PR :)

mortal-ghost commented 2 years ago

Can you please help me regarding this?

Can you tell me what git remote -v shows you?

ss1

Saransh-cpp commented 2 years ago

Great! Please switch to the branch on which you are working and execute the following -

git pull upstream master

This will fetch and merge the master branch from the upstream remote (my repository) into your current branch. It will not merge automatically if there are some merge conflicts, which you will have to handle clear yourself.

Let me know if you face any difficulties!

mortal-ghost commented 2 years ago

Ok , I resolved a lot of conflicts (:laughing:) and made a commit with this error fixed in. Can you please confirm if this is fine now?

Saransh-cpp commented 2 years ago

@mortal-ghost, did you forget to push? :)

mortal-ghost commented 2 years ago

No I pushed the changes. I am getting the option to create a new PR. Should I just create a new one?

Saransh-cpp commented 2 years ago

Yes, create a new one!