search

Saranshmalik / react-native-zendesk

React native wrapper for Zendesk SDK
MIT License
29 stars 42 forks source link

Add setUserIdentity signature in index.d.ts #21

Closed Undermaken closed 3 years ago

Undermaken commented 3 years ago

short description

This PR adds a missing signature about function setUserIdentity that can be invoked both with token or with email & name.

:beetle: It also fixes a bug on Android side about the usage of parameter botName: although it is declared as optional field, native code assumes it is always present.

serbanbjd commented 3 years ago

Maybe you should split the pr-s in two: useridentity and the andriod fixes