Sarcasm / flycheck-irony

C, C++ and Objective-C support for Flycheck, using Irony Mode
56 stars 10 forks source link

Fringe indicators have wrong colors #13

Closed jwintz closed 8 years ago

jwintz commented 8 years ago

Hello Guillaume,

I use irony-mode with company-irony and flycheck-irony.

I have setup flycheck-irony very simply:

(require 'flycheck)
(require 'flycheck-irony)

(eval-after-load 'flycheck '(add-hook 'flycheck-mode-hook 'flycheck-irony-setup))

(add-hook    'c-mode-hook 'flycheck-mode)
(add-hook  'c++-mode-hook 'flycheck-mode)
(add-hook 'objc-mode-hook 'flycheck-mode)

I have disabled all flycheck fringe faces in my theme, or any fringe bitmap in my config to get a vanilla setup.

However, fringe indicators are all red (for errors as well as for warnings and info), while inline waves are colored correctly.

screen shot 2015-11-27 at 20 37 53

Many thanks !

Sarcasm commented 8 years ago

Looks like the way flycheck normal behavior, in the screenshot of their homepage it seems to be the same: http://www.flycheck.org/

jwintz commented 8 years ago

Their screenshots only show warnings. See spacemacs repository for an example where flycheck shows fringe's indicators colored according to their types (info, warning or error).

spacemacs-python

Sarcasm commented 8 years ago

Interesting. Well you should probably try with another mode, elisp or something like that to see if you have the same issue. If you have it then I suggest you to ask the flycheck folks about that. If you don't I can take a deeper look but if you look at flycheck-irony code, which is very short, you will notice that nothing specific is done w.r.t the fringes.

jwintz commented 8 years ago

Very good idea. I have disabled flycheck-inrony and enabled flycheck for emacs-lisp-mode. The issue remains.

screen shot 2015-11-27 at 22 10 02

So it is a flycheck issue. I am closing this ticket.

Thanks for your awesome packages !