search

SardulDhyani / Github-Finder

This is a JavaScript application used to find github users and display their Repos.
1 stars 1 forks source link

Change Color Scheme #1

Closed SardulDhyani closed 4 years ago

SardulDhyani commented 4 years ago

Change color Scheme of the app.

muhammadawaisshaikh commented 4 years ago

what colour you want to change comment the hash colour code.

SardulDhyani commented 4 years ago

Hi, @muhammadawaisshaikh I have used bootswatch in the app, I was thinking of something like changing the current ui to dark theme based ui.

muhammadawaisshaikh commented 4 years ago

ok got your point, we should have to use the toggle of the dark and light version. is it ok for the requirements?

SardulDhyani commented 4 years ago

@muhammadawaisshaikh yes you can also create new toggle or only dark theme will also work. You can do whatever you want 🙂

muhammadawaisshaikh commented 4 years ago

thanks, man. will give you the PR as it has done. I am taking this issue 💯

SardulDhyani commented 4 years ago

ok, @muhammadawaisshaikh I am assigning this to you.

Happy Contributing 🙂🙂

muhammadawaisshaikh commented 4 years ago

it's done. I have created the Pull Request.

muhammadawaisshaikh commented 4 years ago

can you please add this label in your repo "hacktoberfest" you have added "Hacktoberfest" through which your repo is showing as Ineligible Repository in my hacktoberfest profile.

thanks.

SardulDhyani commented 4 years ago

Ok, @muhammadawaisshaikh I'll get back to you after checking your Pr😃

muhammadawaisshaikh commented 4 years ago

close the issue to avoid inconvenience. thanks