SarinaAtkinson-NOAA / FSD-SDDD-Automation

Project management for the Automation Project
Other
0 stars 0 forks source link

Recon. WB->Area xref tables #61

Closed sandraaguilar-noaa closed 2 years ago

sandraaguilar-noaa commented 2 years ago

WB-Area translation tables to reconciliate: WATERBODY_REGION XREF_ALSWATERBODY_AREA

A) There are 151 WB on WATERBODY_REGION that are not in XREF_ALSWATERBODY_AREA and need to be added on the table. B) There are 120 (34 unique areas) discrepancies on the translations that need to be checked. Discrepancies are on "WB_area_neil_discrepancies" table.

I need help on B.
So, I wanted to create two tasks for issues A and B and I created a branch but I am not sure is what we need (learning Git here). Thanks!

SarinaAtkinson-NOAA commented 2 years ago

So we don't have two conversations about the same issue, I'm responding to your email via GitHub :) I will take a look at the discrepancies tables this morning. You will have to show me later what you did to create a branch. I have never done that before with issues.

SarinaAtkinson-NOAA commented 2 years ago

Hi Sandra, In that discrepancies table, it is only when the NB area is between 1 and 21 that we care about. This is because those are areas in the Gulf where the old NMFS area code matches the FIN areas. Perhaps, we should discuss this table over a call before moving forward?

sandraaguilar-noaa commented 2 years ago

That's right! you mentioned yesterday: 1 and 21. Then we only have about 2records!!. But Yes, a quick call would help. Thanks!

sandraaguilar-noaa commented 2 years ago

After meeting with Sarina, I am using NMFS_FIN_AREA_XREF_GOM_SAT_V3 (table that she created) and these are the results: Only 5 discrepancies. Area_Code is how it is right now in sedat table WB->FIN. SAT_area_fin: its using Neil's table and your xref table. SAT=Sarina ATkinson. Sarina can you please tell me which record we keep for each case area_code or SAT_area_fin?

image

sandraaguilar-noaa commented 2 years ago

Missing WB Translations: Now the translations WB->REGION changed: we are using XREF_WATERBODY_AREA table.
WATERBODY_REGION and XREF_ALSWATERBODY_AREA won't be used any more. XREF_WATERBODY_AREA is the result of combining

I implemented this changes in COM_LAND extractions (ALS) and MV has been refreshed.

SarinaAtkinson-NOAA commented 2 years ago

Hi Sandra, Which is the table we are using now in the extraction?

sandraaguilar-noaa commented 2 years ago

Ooops I gave you the wrong name. This is: XREF_WATERBODY_AREA

SarinaAtkinson-NOAA commented 2 years ago

I am receiving an error that this table does not exist....

sandraaguilar-noaa commented 2 years ago

Sorry!!!! ... I mix the names. Please use: XREF_WATERBODY_AREA :)

SarinaAtkinson-NOAA commented 2 years ago

Using the FIN standard codes pdf produced by GulfFIN, I do not see the specific subarea names for ALS waterbodies 9042, 9071, and 9139. That being said, I think we should go with Neil's translation for these discrepancies and change the AREA_FIN to match the AREA_NMFS_CODE.

SarinaAtkinson-NOAA commented 2 years ago

For ALS waterbody 744 and 748, those should remain as discrepancies because the NMFS area code is different than FIN in Florida Bay. The map below are the FIN area codes, where 744 and 748 have corners in FL Bay:

FL keys zoom

The NMFS area codes match the purple zones in the map below where area code 1 covers includes those corners of 744 and 748. Logbook and FIN map FL Keys v2

sandraaguilar-noaa commented 2 years ago

Table was updated and MV refreshed. image

SarinaAtkinson-NOAA commented 2 years ago

Thanks Sandra!