Sarjuuk / aowow

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead
198 stars 211 forks source link

Heroic raid boss not accessible #236

Open BarbzYHOOL opened 3 years ago

BarbzYHOOL commented 3 years ago

Search for "sartharion", you will only find this guy: https://db.rising-gods.de/?npc=28860

And there is no heroic loot associated with it.

Here is the heroic version (I think): https://db.rising-gods.de/?npc=31311

Btw we can see the heroic version shares many loots with the normal version and on wowhead it's not the case, dunno if it's an issue in the cores (TC/AC) or if it's an issue with aowow

BarbzYHOOL commented 3 years ago

Ok, I meant "hard mode boss" and not heroic.

So npc 31311 is for the 25 man raid version? if so, just close this issue :D

Faq commented 3 years ago

in db: image

from tc wiki:

For Dungeons: 
difficulty_entry_1 = 5 (Heroic)

For Raids:
difficulty_entry_1 = 25 (Normal)
difficulty_entry_2 = 10 (Heroic)
difficulty_entry_3 = 25 (Heroic)

So 2 questions:

  1. should there be some reference or in search result show up also Sartharion difficulty_entry_1 when we search for name Sartharion ?
  2. What is that REFERENCE: 34166 thing showing up under loot on this link ?
wodim commented 3 years ago

References are loot groups, it means there's a 100% chance you'll get an item from the group 34166 which has its own items with different %s. The interface to show this is currently pretty poor it seems

BarbzYHOOL commented 3 years ago

1) i think it's just the 25 man version so it's accessible but it's confusing as we can't see its real ID 2) cool tho i can't click the referenced_loot, doesn't open anything for me but i'm on old browser

Sarjuuk commented 3 years ago
1. should there be some reference or in search result show up also Sartharion difficulty_entry_1 when we search for name Sartharion?

Search results? No. That gets cluttered really fast with up to 5 times the results As displayed on the page of the base entity? Maybe in the side bar.

2. What is that **REFERENCE: 34166** thing showing up under loot on this link?

ref-loot is normally merged into the loot as, yes, its fkin confusing to look at unfiltered. As the tcubuntu instance is catered to developers, it is displayed separately, so you can understand how the loot is actually composed. No idea how to better display it.

1. i think it's just the 25 man version so it's accessible but it's confusing as we can't see its real ID  

the 'real' id is the base id. iirc the core uses the base entity and just applies the stats, flags and loot from the placeholder creatures onto it.

2. cool tho i can't click the referenced_loot, doesn't open anything for me but i'm on old browser

it doesn't do anything right now. It's just to display the chances of that reference being merged into the final loot. maybe clicking it could apply a filter to this listview.

wodim commented 3 years ago

No idea how to better display it.

I've thought of something like this (just the design, the data is wrong):

image

Sarjuuk commented 3 years ago

indentations are probably impossible with listviews.

Faq commented 3 years ago

What about adding column with reference ID, next to item name so can also filter out if needed?

Sarjuuk commented 3 years ago

Like the column next to % (drop chance)?

Faq commented 3 years ago

Yeah, would look better 👍