Sarjuuk / aowow

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead
204 stars 217 forks source link

Fatal Error - Maximum execution time of 5 seconds exceeded #275

Closed opiums9 closed 3 years ago

opiums9 commented 3 years ago

After running the application in the CLI, I get this error after a while

"D:\xampp\php\php.exe" aowow --firstrun
...
11:56:16  [OK]    created file datasets/frfr/p-recipes-197
11:56:16  [OK]    created file datasets/dede/p-recipes-197
11:56:16  [OK]    created file datasets/zhcn/p-recipes-197
11:56:16  [OK]    created file datasets/eses/p-recipes-197
11:56:16  [OK]    created file datasets/ruru/p-recipes-197
11:56:16  [OK]    created file datasets/enus/p-recipes-sec
11:56:16  [OK]    created file datasets/frfr/p-recipes-sec
11:56:16  [OK]    created file datasets/dede/p-recipes-sec
11:56:16  [OK]    created file datasets/zhcn/p-recipes-sec
11:56:16  [OK]    created file datasets/eses/p-recipes-sec
11:56:16  [OK]    created file datasets/ruru/p-recipes-sec
11:56:16  [OK]    created file datasets/enus/achievements
11:56:16  [OK]    created file datasets/frfr/achievements
11:56:16  [OK]    created file datasets/dede/achievements
11:56:16  [OK]    created file datasets/zhcn/achievements
11:56:16  [OK]    created file datasets/eses/achievements
11:56:16  [OK]    created file datasets/ruru/achievements
11:56:16          applying 89 baseline exclusions
Fatal Error - Maximum execution time of 5 seconds exceeded @ D:\xampp\htdocs\includes\libs\DbSimple\Mysqli.php:163

What could it be?

Jinnaix commented 3 years ago

This has nothing to do with AoWoW itself but with your webserver / php settings you currently run on. Seems like the default time a script is allowed to run on your current setup is 5 seconds - way to low to setup aowow.

Sarjuuk commented 3 years ago

i think i got it. 5sec is set from the previous step (writing achievement data to file) and the next step (compiling the exclusions file) doesn't reset it because it usually takes mere ms. It should probably get it's own limit and if it's still exceeded .. well than there is another issue.

/e: in general the time limits are set on a 'per setup step' basis. So if it fails you are either running on pretty weak hardware or it's a symptom of a more pressing issue.

Sarjuuk commented 3 years ago

maybe fixed in 7a74c3644847b9fb25b9083656c4df7e62dfcf96 ?

In any case if it still needs more time we should debug this step further.

qyh214 commented 3 years ago

now is Fatal Error - Maximum execution time of 2 seconds exceeded @ xxxx\includes\libs\DbSimple\Mysqli.php:162

commit: 56e70e22bba81692670199c292c231ab0c113cdb