Sarjuuk / aowow

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead
204 stars 217 forks source link

search for custom items,npcs and etc #302

Closed qyh214 closed 3 years ago

qyh214 commented 3 years ago

In /?items you can see a lot of items and include custom items,but if you in search bar try search custom items, and you will give nothing.

Helias commented 3 years ago

Did you generate again the sql data using the setup tool? once you create the new items in item_template you need to re-generate the data to fill the aowow database

qyh214 commented 3 years ago

Did you generate again the sql data using the setup tool? once you create the new items in item_template you need to re-generate the data to fill the aowow database

yes!and also modify item.dbc then use setup tool

Sarjuuk commented 3 years ago

Sounds a bit like a cached search result, if the items show up when accessed directly. Does it work when you disable caching?

qyh214 commented 3 years ago

I have test again and here is note maybe this is not an issue. for example custom item has name_loc0/name_loc2 ,but name_loc4 is empty. and your site set language is zhcn(loc4) search this item will give empty

After review code, it seems that the search system checks the data according to the selected language. If the search object is missing the currently selected language, it cannot be searched. e.g: you add custom item name is A in world.itemtemplate and locale* db is empty.in aowow you set language is 简体中文(zhcn,loc4) in aowow_items name_loc0 is A,but name_loc4 is empty. you search this item and type A,you can not find that. you should also set aowow_items.name_loc4 to A,then you can find this custom item.

so,If you add a lot of custom items/npc,you should set default name and also set locale name then use aowow and update will fine!

so maybe this not an issue and close it.

Perhaps this issue can also tell other users to check this.

Sarjuuk commented 3 years ago

Yes, that's correct.

Another thing for the FAQ, I guess.