Sarjuuk / aowow

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead
204 stars 217 forks source link

Better explanation for profession specialisation extra crafts #358

Closed wodim closed 7 months ago

wodim commented 2 years ago

For example: https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=53901

The way it looks, it seems like there's a 17% chance of getting 1-7 additional items. This is incorrect: there's a 17% chance of getting additional [items to be crafted] items, and if that roll succeeds, there is a 17% chance of getting additional [items to be crafted] items, and so on. In this case (flasks) 2 items are crafted and thus you can get x2 flasks, x4 flasks, etc. but in the case of other crafts such as Spellweave the multiplier is 1.

Therefore there should be a tooltip like these ones that already exist:

image

It could say:

Stack of 2: 17% (this % is wrong: it's 17% minus the sum of all the percentages below) Stack of 4: 2.89% Stack of 6: 0.4913% ...etc

Well maybe not so many decimals... but you get the idea.

Sarjuuk commented 7 months ago

added in 29f80f9a76c41009312dbdefae81821765c69519