Sarjuuk / aowow

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead
204 stars 217 forks source link

Mousing Over no longer displays details since update #393

Closed TQPS closed 6 months ago

TQPS commented 6 months ago

As per title, the mousing over of an item no longer displays full details.

Background & Reproducing Steps:

Caveats:

Deprecated: Creation of dynamic property DbSimple_Mysqli::$_lastQuery is deprecated in C:\Servers\WOTLK.bots_Server\apache\htdocs\database\includes\libs\DbSimple\Mysqli.php on line 160


- Installation does fail towards the end with the following:

Screens

Siteconfig has all correct settings for a local setup:

![image](https://github.com/Sarjuuk/aowow/assets/66294837/f18a929a-e08d-4161-9572-651cf04a091c)

image

Mouse-over/Tooltips are not working. Is this related to the SQL upgrade to 8 where some of the "depreciation warnings" are preventing them? Is it possible the incomplete installation missing a vital step that comes after it aborts?

System:

Sarjuuk commented 6 months ago

https://github.com/Sarjuuk/aowow/blob/25b5928a22694d0b138c8ceac266263e9ebadbda/setup/tools/sqlgen/source.func.php#L266

Maybe rank needs to be in backticks. I faintly remember mysql introducing more keywords.

If you stopped there then about a third of your setup is missing which could very well affect the tooltips.

/e: pretty sure it's rank

As for the deprecation warnings: Those can be ignored for now, but they should not be visible on the page...

Sarjuuk commented 6 months ago

should be better after ec1a2afc5f7aaa243de83e9552ce4fabc14ffcc5

TQPS commented 6 months ago

Confirmed.

Setup detected the previous attempt and continued:

![image](https://github.com/Sarjuuk/aowow/assets/66294837/21c09840-befc-4192-8153-720642ecdb27)

Site loads. Depreciation warnings are gone! Mouse overs and tooltips working again!

![image](https://github.com/Sarjuuk/aowow/assets/66294837/d280447e-b98d-41c5-b572-9c614828f2fe)

Legend! Thank you so much. Sincerely appreciate the hard work that went into the updates!

This issue can be closed as completed.