Sarrus1 / sourcepawn-studio

VSCode extension for SourcePawn scripting
https://sarrus1.github.io/sourcepawn-studio/
MIT License
147 stars 23 forks source link

Update installSM and --syntax-only option in spLinter #256

Closed BoomShotKapow closed 2 years ago

BoomShotKapow commented 2 years ago

Please let me know if you'd like anything modified and I'll get to it as soon as I can.

Thanks!

codecov-commenter commented 2 years ago

Codecov Report

Merging #256 (eac94cf) into master (7244b18) will decrease coverage by 0.25%. The diff coverage is 2.08%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   58.76%   58.50%   -0.26%     
==========================================
  Files          82       82              
  Lines        3196     3208      +12     
  Branches      613      612       -1     
==========================================
- Hits         1878     1877       -1     
- Misses       1123     1136      +13     
  Partials      195      195              
Impacted Files Coverage Δ
src/Commands/installSM.ts 11.84% <0.00%> (-3.68%) :arrow_down:
src/Providers/spLinter.ts 42.85% <50.00%> (+2.85%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sarrus1 commented 2 years ago

Hi, thanks for the PR, and sorry for the delay :/ Everything looks great but I think you need to rollback 6b0cd70, because --syntax-only only exists since 1.11 and some people are using older versions of the compiler. This will probably cause the .smx file to be written and not deleted afterwards.

Other than that, I will merge this PR, thanks again!

BoomShotKapow commented 2 years ago

Sure, no problem. Yea, I probably should've included that in the request. I was mostly just hoping to get rid of that blank compile and I'd assume it'd improve the performance a tiny bit as well. But, I'll revert that change since it's 1.11+ exclusive.

Sarrus1 commented 2 years ago

Thanks for the PR!