Sarrus1 / sourcepawn-studio

VSCode extension for SourcePawn scripting
https://sarrus1.github.io/sourcepawn-studio/
MIT License
143 stars 22 forks source link

spcomp.exe stack, 100% cpu #261

Closed Refzlund closed 1 year ago

Refzlund commented 1 year ago

Basic informations

Further Information

When working with methodmaps my computer started taking off. image

I don't know the root of the cause, other than methodmaps being when it started with repeated compilers.

To Reproduce

  1. Make a methodmap entry in your .sp code
  2. Make some kind of invalid code (?)
  3. methodmap HelloThere {
    public native bool 
    }
  4. image

Expected behaviour

I would expect the previous ongoing compile to be closed — giving an error — limited to 1-2 compiles at a time, or shutting down the extension host as an error.

Error messages

These may or may not have occurred when I forced the processes to stop.

[Extension Host] TypeError: Cannot read properties of null (reading 'text')
    at ib (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:440:9234)
    at Sp.walkTree (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:714)
    at ed (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:86)
    at hb (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:443:90)
    at Timeout._onTimeout (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:1718)
    at listOnTimeout (node:internal/timers:559:17)
    at process.processTimers (node:internal/timers:502:7) (at console.<anonymous> (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:90:142292))
log.ts:313   ERR Cannot read properties of undefined (reading 'name'): TypeError: Cannot read properties of undefined (reading 'name')
    at nv (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:485:6076)
    at Cd.provideCompletionItems (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:485:11403)
    at K.provideCompletionItems (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:92:51689)
    at c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:92:76815
    at ne._withAdapter (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:92:66986)
    at ne.$provideCompletionItems (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:92:76791)
    at i._doInvokeHandler (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:100:13680)
    at i._invokeHandler (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:100:13362)
    at i._receiveRequest (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:100:12081)
    at i._receiveOneMessage (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:100:10834)
    at c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:100:8941
    at p.invoke (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:145)
    at v.deliver (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:2266)
    at b.fire (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:1844)
    at c.fire (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:69:19049)
    at c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:116:17106
    at p.invoke (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:145)
    at v.deliver (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:2266)
    at b.fire (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:61:1844)
    at c.fire (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:69:19049)
    at MessagePortMain.<anonymous> (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:116:15146)
    at MessagePortMain.emit (node:events:526:28)
    at MessagePortMain._internalPort.emit (node:electron/js2c/utility_process_init:5:364)
13console.ts:137 [Extension Host] TypeError: Cannot read properties of null (reading 'text')
    at ib (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:440:9234)
    at Sp.walkTree (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:714)
    at ed (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:86)
    at hb (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:443:90)
    at Timeout._onTimeout (c:\Users\yruge\.vscode-insiders\extensions\sarrus.sourcepawn-vscode-4.2.1\dist\spIndex.js:442:1718)
    at listOnTimeout (node:internal/timers:559:17)
    at process.processTimers (node:internal/timers:502:7)
dran1x commented 1 year ago

Pretty much the same as #63 I don't think the issue was ever solved. What SourcePawn Compiler version are you currently using for your project though?

Refzlund commented 1 year ago

Pretty much the same as #63 I don't think the issue was ever solved. What SourcePawn Compiler version are you currently using for your project though?

Ah — yes. I'm using the default one provided by the extension at user/sourcemodAPI. Can't tell the version. I'll try to work a bit on the compiler that comes with `sourcemod-1.11.0´ and see if it makes a difference.

I do relate to https://github.com/Sarrus1/sourcepawn-vscode/issues/63 statement of

I suspect that this comes from the linter, which never closes when the compile fails.

I'll let you know if the issue persists.

Sarrus1 commented 1 year ago

Thanks for reporting this issue.

I had someone reach out to me on Discord a while back with the same issue, which was also resolved by updating the compiler.

I'll let you know if the issue persists.

👍

Refzlund commented 1 year ago

Reoccurs seemingly at random;

image

Using SourcePawn Compiler 1.11.0.6911 via sourcemod-1.11.0, which I've downloaded and selected via
"sourcepawn.SpcompPath": "C:/Users/username/Documents/MEGA/Gits/csgo-plugins/sourcemod/scripting/spcomp64.exe" — from VSCode workspace settings;
C:/Users/username/Documents/MEGA/Gits/csgo-plugins/.vscode/settings.json

Sarrus1 commented 1 year ago

Fixed in v5 with the use of the LSP.