caxanga334 commented 1 year ago

Basic informations

OS: Windows 10
VSCode version: 1.73.1
Extension version: 4.2.3

Further Information

This extension fails to parse the include files of the CBaseNPC extension. So autocomplete doesn't include anything from those files.

To Reproduce

Add the CBaseNPC include to a plugin.
Start writing any function or methodmap from the CBaseNPC extension.

Code to reproduce the behaviour

#include <sourcemod>
#include <cbasenpc>

#pragma newdecls required
#pragma semicolon 1

public void OnPluginStart()
{
    // start writing any function or methodmap from CBaseNPC
    // IE: CBaseNPC_GetNextBotOfEntity

}

Expected behaviour

The autocomplete should list all available functions, methodmaps, enums, etc from the CBaseNPC extension.

Error messages

No error message related to this extension appears.

Possible cause of the issue

While testing things I found something. The CBaseNPC extention include files are written like this:

#if !defined DEFNAME
#define DEFNAME

<CODE HERE>

#endif

While sourcemod default includes are written like this:

#if defined DEFNAME
 #endinput
#endif
#define DEFNAME

<CODE HERE>

If I modify the CBaseNPC extension to follow the style of sourcemod default includes, autocomplete start working as normal.

The files are being parsed but it fails to read them properly because only the #define DEFNAME are listed for autocomplete.

screenshot_vscode_autocomplete

Sarrus1 commented 1 year ago

Thank you for reporting this. The preprocessor needs some rework, and I am currently writing a new version of the parser over here.

I will make sure to address this problem there 👍