search

Sarrus1 / sourcepawn-studio

VSCode extension for SourcePawn scripting
https://sarrus1.github.io/sourcepawn-studio/
MIT License
147 stars 23 forks source link

Update the plugin workflow templates #282

Closed tsuza closed 1 year ago

tsuza commented 1 year ago

The extension's workflow templates are a great way to quickly have a proper way to build and release plugins on github. However, they're out-of-date ( they can't create releases anymore ) and lack some nice-to-have functionalities.

tsuza commented 1 year ago

I've tested these changed on a private repository and also generating them by swapping the original files in the extension's vscode folder.

Sarrus1 commented 1 year ago

Hi @Zabaniya001 thanks a lot for the PR, I'm finally going to merge it, after you make the requested changes. Again, sorry for the delay, was busy porting to the new LSP :)

tsuza commented 1 year ago

Alright, I've made the requested change. Personally, I'm leaning more towards the older approach ( build on commit ) since most people would rather have a "drop and forget" method to compile their repositories ( including me ) and they'll most likely forget to make a new tag in the first place.

If you don't want to compile it, just put in the commit name the [ci] tag and you're set. Otherwise, it'll compile and just replace the artifacts, which is not a big deal.

I don't think this will make people version their plugins better and it'll end up just being a hassle.

Though, ultimately I don't mind the change.

Sarrus1 commented 1 year ago

Merged, thanks a bunch!