code coloring issues

[ProjectSky]

Basic informations

• OS: [Windows]
• VSCode version: Latest
• Extension version: Latest

Further Information

To Reproduce

idk how it happened, I just opened working directory and edited some script files

Code to reproduce the behaviour

Expected behaviour

Error messages

[Sarrus1]

Thank you for reporting.

Does this eventually go away? What happens if you restart the server?

[ProjectSky]

Thank you for reporting.

Does this eventually go away? What happens if you restart the server?

• If I disable server, code coloring works again. restart server will not change anything

• some log

  [Error - 21:48:10] Request textDocument/documentSymbol failed.
  Error: name must not be falsy
  at s.validate (c:\Users\skyor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:103:16960)
  at new s (c:\Users\skyor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:103:17255)
  at ye (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:34:73456)
  at ye (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:34:73637)
  at o (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:34:48563)
  at Object.tj [as map] (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:34:48649)
  at Object.wr [as asDocumentSymbols] (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:34:73423)
  at c (c:\Users\skyor\.vscode\extensions\sarrus.sourcepawn-vscode-6.0.2-win32-x64\dist\spIndex.js:38:56041)
  at async s.provideDocumentSymbols (c:\Users\skyor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:109:38034)

[Sarrus1]

Thanks, can you send me the project you are working on so that I can reproduce please?

[ProjectSky]

Thanks, can you send me the project you are working on so that I can reproduce please?

here is the working directory/code to reproduce this issue sp.zip

[Sarrus1]

Weird it does not happen for me... Can you try on v6.1.0? I fixed a lot of preprocessor stuff.

[Sarrus1]

Moving the symbolRequest bug to #345.

[ProjectSky]

Weird it does not happen for me... Can you try on v6.1.0? I fixed a lot of preprocessor stuff.

Strange, I'm using v6.1.0, I'll switch to a clean environment and retest it.

[Sarrus1]

Can you try setting the logs to DEBUG as well?

[ProjectSky]

Can you try setting the logs to DEBUG as well?

debug.txt

[Sarrus1]

Ok two more things:

• Your includesDirectories setting is empty, is it intentional?
• Do "ctrl + shift + p" and type "debug pre sourcepawn". And send me the output please.

[ProjectSky]

Ok two more things:

• Your includesDirectories setting is empty, is it intentional?
• Do "ctrl + shift + p" and type "debug pre sourcepawn". And send me the output please.

1: yes (nothing will change even if I set it) 2: unknown command debug pre sourcepawn

trace.txt

[Sarrus1]

Sorry I mixed up the name:

https://github.com/Sarrus1/sourcepawn-vscode/blob/main/editors/code/package.json#L136

Should be "reveal preprocessed document"

[ProjectSky]

Sorry I mixed up the name:

https://github.com/Sarrus1/sourcepawn-vscode/blob/main/editors/code/package.json#L136

Should be "reveal preprocessed document"

trace.txt

[Sarrus1]

Thanks, can you also send a screenshot of your screen? I think the command opens a panel on the right. I need the two documents side by side please.

The output you sent me is encoded in utf-8 so the chinese characters are not properly rendered :/

[ProjectSky]

Thanks, can you also send a screenshot of your screen? I think the command opens a panel on the right. I need the two documents side by side please.

The output you sent me is encoded in utf-8 so the chinese characters are not properly rendered :/

[Sarrus1]

Ok so on the screenshot the coloring errors are because the macros are expanded and the servers "sees" the tokens that were expanded. This I can fix.

But on the very first screenshot you sent, the highlighting errors are not on the same line as the macros, can you send a screenshot where there is a highlighting error on a line that does not have a macro please?

[ProjectSky]

It seems that code highlight issues only occur after macros

[Sarrus1]

Ok this was probably fixed in 0.12.0 of the LSP, with either the deadlock fix or the preprocessor fix. I am closing this issue, but if the bug reappears on a line that does not have a macro, please feel free to reopen this issue.

I am tracking the macro line highlight issue in #333.

Thank you for all the debug information 🚀

[ProjectSky]

Thank you for your hard work. By the way, I'd like to offer some support, but buymeacoffee cannot be used in China (:

[Sarrus1]

Thanks! I have a paypal as well: omegasix0611@gmail.com

Glad you like the extension!

[ProjectSky]

Thanks! I have a paypal as well: omegasix0611@gmail.com

Glad you like the extension!

paypal: Sorry, this recipient can’t accept payments right now :(

[ProjectSky]

Oh crap right, try: charleszablit@gmail.com

Done

[Sarrus1]

Thank you!