Add support for custom server RCON commands

maxijabase commented 2 months ago

Duplicate of #376 from a feature branch.

maxijabase commented 2 months ago

Currently the only macro I'm supporting is {plugin}, which will get replaced by the plugin that was compiled.

maxijabase commented 2 months ago

Added support for custom commands to be sent to the server via RCON. Placeholder macro available: ${plugin}
Fixed some cases of the code editor losing focus when compiling, and other related bugs
Added progress, confirmation and error notifications when uploading files via (S)FTP or sending RCON commands.
Fixed compiler.path setting not being used to locate the compiler. spCompPath should be properly deprecated now.

Source code-wise

Changed ftp-deploy package for ssh2-sftp-client for SFTP and basic-ftp for FTP. They are a little more verbose (don't accept grub filters by default) but they had types for nicer development - we ought to see if the tradeoff is worth it.
Polished config access (user settings) to simplify code.

TODO

~~Make sure RCON command execution happens only if the Upload command promise has been fulfilled~~
~~Fix notifications overlapping and disappearing for some confirmations~~
Add nicer and clearer separations to the extension configuration
Test ftp refactors more thoroughly
Replace all "Open Settings" occurrences in notifications with more precise setting IDs for better UX instead of @ext:sarrus.sourcepawn-vscode
Keep adding comments and checking the rest of the code for improvements
Keep checking for usage of deprecated settings (and remove them?)

maxijabase commented 2 months ago

Improved createTask command - fixed not adjusting for new configs and removed template file
Fixed upload or run commands commands executing even if the compilation failed.
Fixed run commands command running when afterCompile was set only if uploadAfterSuccessfulCompile was set to true.
Removed progress notification in run commands command to avoid weird notifications behavior.

Probably a good idea to review the settings' names of the upload and run commands commands execution order/preferences.

Sarrus1 commented 2 months ago

Probably a good idea to review the settings' names of the upload and run commands commands execution order/preferences.

Could be runServerCommandsOnSuccessfulUpload ?

maxijabase commented 2 months ago

changeSMApi command: added check for empty APIs array, or any API with name === "" before rendering list.
Added an editConfig() in the code similar to getConfig(), and used the setting ID to lead the user to the specific setting triggering the notification easier.
Added outputDirectoryPath as a property of AvailableAPIs (#379)

maxijabase commented 2 months ago

What's the python Scraper for?

Sarrus1 commented 2 months ago

What's the python Scraper for?

It used to be an attempt at parsing the CS:GO Cvars to be able to autocomplete them in cfg files

Sarrus1 / sourcepawn-studio