[feat] message on wrong IFSC input

Sarthak-Mittal / ifsc

An application to query bank details based on IFSC code. Client implementation for RazorPay IFSC https://github.com/razorpay/ifsc API

https://sarthak-mittal.github.io/ifsc/

MIT License

1 stars 7 forks source link

[feat] message on wrong IFSC input #3

Closed ayaankhan98 closed 4 years ago

ayaankhan98 commented 4 years ago

Display a message if no data found related to the entered IFSC code.

shubhi23994 commented 4 years ago

I can take this up

ayaankhan98 commented 4 years ago

sure go ahead @shubhi23994

Sarthak-Mittal commented 4 years ago

Hey! Before getting starting, let us discuss how you plan to proceed. I have two ideas ATM:

A custom validator for the IFSC code input field, maybe regex based. It would not spam the API in case of an invalid IFSC code.
A styled yet decent "No data found" or "Invalid IFSC code" message in the case when invalid data is returned from API.

If you have some other suggestions, let's discuss it. @shubhi23994 @ayaankhan98

ayaankhan98 commented 4 years ago

@Sarthak-Mittal i think a regex based validator will not give accurate results always, it will be good if @shubhi23994 goes with both approaches first check the given IFSC with regex if it's is valid according to regex then fetch the data from the API, at this point there are two possible cases we can have valid data in one case and invalid in other case, if data is invalid then simply put a decent message on screen.

Sarthak-Mittal commented 4 years ago

Yes, this sounds good @ayaankhan98 . @shubhi23994 you may proceed on these lines.

Sarthak-Mittal commented 4 years ago

@shubhi23994 do we have any update on this?

shubhi23994 commented 4 years ago

@Sarthak-Mittal I started working on this yesterday but since I have a linux system , I am facing issues with ng command. Getting any other environment can take some time.So won't be able to work on this before weekend. So if anyone else volunteer for this you can re-assign it.

ayaankhan98 commented 4 years ago

@Sarthak-Mittal I started working on this yesterday but since I have a linux system , I am facing issues with ng command. Getting any other environment can take some time.So won't be able to work on this before weekend. So if anyone else volunteer for this you can re-assign it.

@shubhi23994 can you please mention what problem you are facing on linux along with your linux specification?

shubhi23994 commented 4 years ago

@Sarthak-Mittal Initially I was getting ng commands issue but I think that was because of the node version. I have resolved the issue. Will update you on the progress soon. Sorry for the delayed response!

Sarthak-Mittal commented 4 years ago

Hey @shubhi23994 , I wanted to make sure if things were still in progress. Let me know what's the update on it.

rohanshenoy96 commented 4 years ago

Hi @Sarthak-Mittal @ayaankhan98. I was also working on this. I'm attaching screenshots let me know if u need anything else in this Error case Success case

Sarthak-Mittal commented 4 years ago

Looks good to me!

rohanshenoy96 commented 4 years ago

Created a pull request. Please verify and let me know if anything else is required @Sarthak-Mittal

Sarthak-Mittal commented 4 years ago

Thanks @rohanshenoy96 for your contributions. Merged #26 for this.