Closed IshaanShettigar closed 10 months ago
@IshaanShettigar, Kindly elaborate on the bug that you have fixed.
It is the error that I mentioned at the end of my PR #443.
I noticed a small error where the Gravitational Force shows NaN N, instead of the error message, when the button is clicked once. (It shows the proper error message only when clicked twice). I apologize for this oversight. This error happened due to the fact that the parseFloat was async while the code that checks for the error is sync so I had to modify it a bit by using useEffect
and it worked fine.
@IshaanShettigar, No worries, thanks for mentioning the error and responsibly fixing the same.
Congratulations 🎉 @IshaanShettigar on your contribution. Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Issue Id you have worked upon -
406
Briefly explain your program logic -
I have created two TextFields with the appropriate error messages in case the input is wrong. Created 3 main states to handle the two inputs + the output. Also created 4 pieces of state to handle the error state. (one for whether to show the error and one for the error message, both of these are applied to two inputs, mass and height).
Screenshots(Attach 2 screenshots of your own input and output) -
By raising this PR I affirm that -
[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code.
[x] My code gives the correct output.
[x] I affirm that I strictly follow contributing guidelines and code of conduct.