Momentum Calculator - Githubissues

SarthakKeshari / calc_for_everything

This repository aims to provide Calculators for educational, professional, scientific, health and well-being and other purposes.

https://calc-for-everything-psi.vercel.app

MIT License

113 stars 103 forks source link

Momentum Calculator #535

Closed Pasqua101 closed 10 months ago

Pasqua101 commented 10 months ago

Issue Id you have worked upon -

Issue #531

Briefly explain your program logic -

As mentioned in issue #531. I have created a momentum calculator that takes in mass (kg) and velocity (m/s) and returns a value of kg m/s for the momentum. There is also has a info file explaining the purpose of the calculator.

Additionally, I have added this calculator to the list of currently implemented physics calculators and removed the duplicate physics header from the README.

Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code.
[x] My code gives the correct output.
[x] I affirm that I strictly follow contributing guidelines and code of conduct.

SarthakKeshari commented 10 months ago

@Pasqua101, In the readme file while adding your changes, you have removed the Physics section. Kindly revert the Readme file.

Pasqua101 commented 10 months ago

Hi @SarthakKeshari , I only removed a duplication of the Physics section. Please look at the attached screenshot below that shows the deletion of the duplicate Physics section that opts for the one that has more of the calculators.

Additionally, you can see this duplication on the current version of the README on the main page. As seen below.

The changes to made to the README address this duplication. However, if this is not what you want, I can revert this. Please let me know. Thank you.

SarthakKeshari commented 10 months ago

@Pasqua101, Thanks for the help. I got your point. 😊

SarthakKeshari commented 10 months ago

@Pasqua101, Glad to see you have updated the Info file. Appreciating your efforts by adding admin-appreciation points. 👏👏

SarthakKeshari commented 10 months ago

Congratulations 🎉 @Pasqua101 on your contribution. Thanks for adding value to this repository. 😊

Let's celebrate this fest 😃 by providing more developers 👨‍💻👩‍💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.

Your efforts can make difference.

SarthakKeshari commented 10 months ago

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐

Pasqua101 commented 10 months ago

Done. Thanks for accepting my PR!