search

SarthakYadav / jax-mae

Masked Autoencoders in Jax
MIT License
5 stars 1 forks source link

deterministic = train or = not train? #2

Closed davidshen84 closed 1 year ago

davidshen84 commented 1 year ago

https://github.com/SarthakYadav/jax-mae/blob/main/mae/models/mlp.py#L38

I think it should be deterministic=not train.

SarthakYadav commented 1 year ago

Hi @davidshen84 ,

Yes, that's correct, it should be deterministic=not train. Mlp dropout is not used by default, so we're not messing things up big time for now.

SarthakYadav commented 1 year ago

Fixed in commit 5f95617. Thanks for reporting this issue, closing it now.