Sarveshgithub / sfdc-lwc-lightning-datatable

Salesforce Lighting Data table
MIT License
78 stars 28 forks source link

Picklist edit #164 #166

Closed mickaelgudin closed 1 year ago

mickaelgudin commented 1 year ago

Description

Fixes #164

Type of change

How Has This Been Tested?

Tests

Sarveshgithub commented 1 year ago

@mickaelgudin thanks for your contribution,

For testing:

mickaelgudin commented 1 year ago

@Sarveshgithub

for testing :

Sarveshgithub commented 1 year ago

@mickaelgudin ok sounds good, let me know once log are removed

mickaelgudin commented 1 year ago

@Sarveshgithub I removed the console.log statements

Sarveshgithub commented 1 year ago

hi @mickaelgudin, i have tested this change, getting an error, 'Unscripted error' in Org, and this is not working in local dev ( localhost ). getting below error: Steps to reproduce :

  1. Start local dev server
  2. configLocal(this, true); // set this to true
  3. Open lwcRelated component image
mickaelgudin commented 1 year ago

@Sarveshgithub I don't use localdevserver,

did you deploy other components? (datatablePicklistColumn, extendedDatatable).

It's working great in sandbox environment, I think the error says that you can't have child components(since there is a dependency with the new components)

Sarveshgithub commented 1 year ago

@mickaelgudin Yes, I have deployed it's failing in org as well, but it should work in local dev as well, no sure why it's failing

mickaelgudin commented 1 year ago

@Sarveshgithub are you deploying using git deploy button or through xml manifest?

Sarveshgithub commented 1 year ago

@mickaelgudin deploying via VS code directly from 'dev' branch

mickaelgudin commented 1 year ago

@Sarveshgithub alright I will look into it, I'll keep you posted

Sarveshgithub commented 1 year ago

@mickaelgudin I have analzed, import LightningDatatable from 'lightning/datatable'; this is not supported in localhost dev. In org working fine. all good