search

Sarveshgithub / sfdc-lwc-lightning-datatable

Salesforce Lighting Data table
MIT License
78 stars 28 forks source link

Retain existing WHERE clause when performing search #189

Closed e-bacho closed 1 year ago

e-bacho commented 1 year ago

When a WHERE clause is specified via the design attribute, the search component ignores/overwrites it.

welcome[bot] commented 1 year ago

Thanks for opening this pull request! Please check out our contributing guidelines.

mickaelgudin commented 1 year ago

@e-bacho good finding, thank you very much indeed. If you wish to contribute next time make sure to use the dev branch for PR.

@Sarveshgithub I tested the provided change it's all good. Could you merge it on the master and dev branches ?

e-bacho commented 1 year ago

No worries at all @mickaelgudin. Will make future PRs against dev

Sarveshgithub commented 1 year ago

thanks, @e-bacho for contributing, thanks @mickaelgudin looking into it, I'll merge thanks

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! We here at SarveshGithub are proud of you!