search

SasView / sasdata

Package for loading and handling SAS data
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Refactor nxsunit #13

Closed krzywon closed 1 year ago

krzywon commented 2 years ago

This overhauls the nxsunit module to allow scaling with offsets, and scaling of multi-dimensional and complex units, e.g. SESANS A^-2*cm^-1 will treat the A^-2 and cm^-1 as separate components, each independently scalable. Unit tests were moved from within the module to the global unit test suite.

Fixes #5 Fixes(?) sasview/sasview#2035 - @pkienzle what do you think?

butlerpd commented 1 year ago

Still waiting for review by @pkienzle and @lucas-wilkins (though the latter will be after Jan 1 I guess?). @wpotrzebowski may also take a look.

butlerpd commented 1 year ago

is this ready to merge?