SasView / sasdata

Package for loading and handling SAS data
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

changed xaxis label for updated SESANS nomenclature from z to delta #60

Closed caitwolf closed 8 months ago

caitwolf commented 9 months ago

This fixes #59 which is referencing the original SasView issue https://github.com/SasView/sasview/issues/2663. This only updates the label on the 1D plot. The residuals plot is fixed in a separate sasview PR (https://github.com/SasView/sasview/pull/2754).

krzywon commented 9 months ago

This seems reasonable so far. There are no new doc warnings, and the build failures match the failures already documented in #57.

butlerpd commented 9 months ago

assuming the corresponding sasview PR gets merged into 6.0.0 this will need to get merged into 0.9.0 as well

caitwolf commented 8 months ago

I made requested changes in the paired SasView PR and made sure those changes were reflected in the new file locations in sasdata (it looks like changes were made in both places which helped with this).