search

SasView / sasmodel-marketplace

A website for sharing custom sasmodel files
1 stars 2 forks source link

Update help for Pringle-Schmidt helix model #31

Closed smk78 closed 1 year ago

smk78 commented 1 year ago

The help docstrings for the Pringle-Schmidt model should be updated to clarify that it can be used as a single helix model.

See discussion in https://github.com/SasView/sasmodels/issues/417

smk78 commented 1 year ago

The P-S Helix model on the new Marketplace (https://marketplace.sasview.org/models/150/) has been revised and the following comment added:

This is a revision of the model originally posted to the old Marketplace. The description has been updated to clarify that the model can be used to fit a single helical tape. In testing it was also discovered that the model would not compile because one of the angle parameters was called phi. Phi has a special meaning in SasView, being one of the orientational parameters. All references to phi in this model were therefore changed to epsilon. The model now works, but it remains untested!