search

SasView / sasmodel-marketplace

A website for sharing custom sasmodel files
1 stars 2 forks source link

Fix model download from marketplace (Trac #838) #7

Closed sasview-bot closed 5 years ago

sasview-bot commented 5 years ago

From email to ajj:

After uploading the Pringle-Schmidt model for Ian to the !SasView marketplace online we discovered a small bug with the marketplace file downloader. Although if you click on the file link on the model description page (i.e. http://marketplace.sasview.org/uploads/8) it shows the file's contents, however, clicking the link at the bottom of the page returns a file that only contains the text:

'!NoneType' object has no attribute 'read'

I have tried this for models 2, 4, 6 & 8 all of which return the same file. Any ideas as to why this is occurring?

Regards,

Tim

Migrated from http://trac.sasview.org/ticket/838

{
    "status": "closed",
    "changetime": "2017-04-05T16:02:41",
    "_ts": "2017-04-05 16:02:41.077627+00:00",
    "description": "From email to ajj:\n\nAfter uploading the Pringle-Schmidt model for Ian to the !SasView marketplace online we discovered a small bug with the marketplace file downloader. Although if you click on the file link on the model description page (i.e. http://marketplace.sasview.org/uploads/8) it shows the file's contents, however, clicking the link at the bottom of the page returns a file that only contains the text:\n\n    '!NoneType' object has no attribute 'read'\n\nI have tried this for models 2, 4, 6 & 8 all of which return the same file. Any ideas as to why this is occurring?\n\n\nRegards,\n\n  Tim",
    "reporter": "tim",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasModels Marketplace",
    "time": "2017-01-17T13:07:52",
    "component": "sasmodels Markeplace",
    "summary": "Fix model download from marketplace",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.2.0",
    "owner": "wojciech",
    "type": "defect"
}
wpotrzebowski commented 5 years ago

Trac update at 2017/01/30 13:24:14: wojciech commented:

Path to models is wrong. It is http://marketplace.sasview.org/uploads/marketplace.sasview.org/uploads/uploaded_models/pringle_schmidt_helices.py and should be http://marketplace.sasview.org/uploads/uploaded_models/pringle_schmidt_helices.py. Need to change base url probably.

ajj commented 5 years ago

Trac update at 2017/01/31 09:19:25:

wpotrzebowski commented 5 years ago

Trac update at 2017/02/10 10:52:22: wojciech commented:

The fix has been pushed but automatic deployment hasn't been triggered. Andrew will look into this.

butlerpd commented 5 years ago

Trac update at 2017/03/07 05:20:45: butler changed description from:

From email to ajj:

After uploading the Pringle-Schmidt model for Ian to the SasView marketplace online we discovered a small bug with the marketplace file downloader. Although if you click on the file link on the model description page (i.e. http://marketplace.sasview.org/uploads/8) it shows the file's contents, however, clicking the link at the bottom of the page returns a file that only contains the text:

'NoneType' object has no attribute 'read'

I have tried this for models 2, 4, 6 & 8 all of which return the same file. Any ideas as to why this is occurring?

Regards,

Tim

to:

From email to ajj:

After uploading the Pringle-Schmidt model for Ian to the !SasView marketplace online we discovered a small bug with the marketplace file downloader. Although if you click on the file link on the model description page (i.e. http://marketplace.sasview.org/uploads/8) it shows the file's contents, however, clicking the link at the bottom of the page returns a file that only contains the text:

'!NoneType' object has no attribute 'read'

I have tried this for models 2, 4, 6 & 8 all of which return the same file. Any ideas as to why this is occurring?

Regards,

Tim

butlerpd commented 5 years ago

Trac update at 2017/03/08 14:53:40:

This is really an admin task and not a 4.1 release blocker - though it would be REALLY nice to be able to release 4.1 with announcement of a working marketplace. Still, as we are closing down work on 4.1 release am moving this to 4.2 so as not to confuse things along with ticket #2

smk78 commented 5 years ago

Trac update at 2017/03/08 15:03:37: smk78 commented:

And you can always highlight the code for a model, select, copy, and paste into an editor, so it's not like the models are unattainable. Agree, not a blocker.

ajj commented 5 years ago

Trac update at 2017/04/05 16:01:15:

Fixed by @wojciech in commit [https://github.com/SasView/sasmodel-marketplace/commit/80731868511c584f33a39e716da2e15199a667ef 80731868]