Open pkienzle opened 5 years ago
@dehoni or @pkienzle - this is an old ticket. Does it still apply? I'm suspecting yest but just wanted to make sure that it should not be closed.
Most of the shape-independent model fall under this ticket. It is relatively easy to extract the calculations in a c file, which should resolve the issue.
PR #58 is another possibility: automatically translate python models to c.
PR #58 is another possibility: automatically translate python models to c.
The PR 247-pure-python-models-do-not-support-magnetism-or-orientation-trac-1048 will only touch models that had an embedded c code. For pure Python models, I second the idea to automatically translate python models to c. Not imposing to write c code for even a simple model definition also lower a scaring hurdle for normal users. Many people have some experience with python and would be willing to write a model in the language. The discussion about how to go forward and handle Python models is already part of the discussion in PR #58.
Shape-based user models will not support magnetism or orientation unless they are automatically converted to C using #58 or kernelpy.py
is updated to handle magnetism and orientation.
Code from kernel_iq.c has not been ported to kernelpy.py. In particular, the new orientation and magnetism algorithms do not apply to pure python models.
Migrated from http://trac.sasview.org/ticket/1048