search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

update tests for bcc/fcc paracrystal and core shell parallelepiped (Trac #1036) #289

Open pkienzle opened 5 years ago

pkienzle commented 5 years ago

bcc and fcc paracrystal 2D were modified during the orientation rewrite but the tests were not updated.

core shell parallelepiped calculation was corrected but the test target values were not.

Migrated from http://trac.sasview.org/ticket/1036

{
    "status": "new",
    "changetime": "2018-02-13T02:25:56",
    "_ts": "2018-02-13 02:25:56.006821+00:00",
    "description": "bcc and fcc paracrystal 2D were modified during the orientation rewrite but the tests were not updated.\n\ncore shell parallelepiped calculation was corrected but the test target values were not.\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2017-11-22T17:50:31",
    "component": "SasView",
    "summary": "update tests for bcc/fcc paracrystal and core shell parallelepiped",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
pkienzle commented 5 years ago

Trac update at 2017/11/27 20:03:00: pkienzle commented:

add 2=D tests for various rectangular prism models.

butlerpd commented 5 years ago

Trac update at 2018/02/13 02:25:56: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

butlerpd commented 2 years ago

Since builds require all tests to pass these days and they clearly have been I am guessing we can close this old issue nnow?